Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vt add getRenderedFeaturesAsync #8

Merged
merged 2 commits into from
Jun 11, 2024
Merged

vt add getRenderedFeaturesAsync #8

merged 2 commits into from
Jun 11, 2024

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented Jun 11, 2024

fix maptalks/issues#639

目前的features转换没有采用clone模式,即只会转换一次,如果发现geometry已经符合geojson规范了就不在转了

  • 不确定这样是否有bug,
  • 我认为是只需要转换一次,因为数据更新了老的features应该失效才对
  • 样式更新和features无关
  • 大块头的数据,可以在文档里推荐用户使用该方法,来解决卡主线程的问题

@deyihu deyihu requested a review from fuzhenn June 11, 2024 08:39
@fuzhenn
Copy link
Owner

fuzhenn commented Jun 11, 2024

收到,但需要补充测试用例

@fuzhenn
Copy link
Owner

fuzhenn commented Jun 11, 2024

测试可以参考 packages/vt/test/layer.spec 下的getRenderedFeatures的用例

@fuzhenn fuzhenn merged commit 2a34292 into fuzhenn:master Jun 11, 2024
@fuzhenn fuzhenn deleted the 639 branch June 11, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VectorTileLayer的getRenderedFeatures方法返回的是矢量瓦片中的坐标,而不是经纬度
2 participants