Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the refactored gocui SetCurrentView method. #229

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Handle the refactored gocui SetCurrentView method. #229

merged 1 commit into from
Oct 24, 2016

Conversation

oswell
Copy link
Contributor

@oswell oswell commented Oct 21, 2016

Previously, the method just returned an error if an error occurred (or nil if no error).
The new method now returns the view as well as well as the error object. Updated to ignore the
view and handle the error object as usual.

Fix for issue #228.
#228

@kotakanbe
Copy link
Member

Hi, @oswell

Thanks so much :)

Vuls uses glide for package management.
/~https://github.com/Masterminds/glide

Could you please also update glide.lock?
/~https://github.com/future-architect/vuls/blob/master/glide.lock

@oswell
Copy link
Contributor Author

oswell commented Oct 22, 2016

@kotakanbe Ahhh, I have never used glide so didn't notice that. I'll update it later tonight on this branch. Explains why I was seeing the issue and nobody else was complaining. :)

@kotakanbe
Copy link
Member

@oswell

It's OK.

README: /~https://github.com/future-architect/vuls#step5-deploy-vuls

Step5. Deploy Vuls

Launch a new terminal and SSH to the ec2 instance.

$ mkdir -p $GOPATH/src/github.com/future-architect
$ cd $GOPATH/src/github.com/future-architect
$ git clone /~https://github.com/future-architect/vuls.git
$ cd vuls
$ make install

Makefile: /~https://github.com/future-architect/vuls/blob/master/Makefile

deps: glide
    glide install

install: main.go deps
    go install -ldflags "$(LDFLAGS)"

glide install will git clone and git checkout to specific version that is defined in glide.lock.
So, you can compile by make install even if this case.

@oswell
Copy link
Contributor Author

oswell commented Oct 22, 2016

@kotakanbe Fixed. Glide actually makes sense and solves issues I've had with go in general, though I'm fairly new to it as a language, so figured there must be something out there to handle this.

I've had a habit of just using go get, go build, and go install up to now.

@kotakanbe
Copy link
Member

@oswell

Tested.
I am going to merge to master, would you merge in only one commit?
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@oswell
Copy link
Contributor Author

oswell commented Oct 24, 2016

@kotakanbe
Assuming I did that correctly, it should be good now.

-thx

@kotakanbe kotakanbe merged commit 6f012fc into future-architect:master Oct 24, 2016
@kotakanbe
Copy link
Member

@oswell

Many Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants