This repository has been archived by the owner on Aug 8, 2020. It is now read-only.
Add "timid" attribute to Output sink to avoid unnecessary touching #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furfurylic
added a commit
that referenced
this pull request
Oct 22, 2017
Add "timid" attribute to Output sink to avoid unnecessary touching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds "timid" attribute to Output sink. When this attribute is set
true, the sink checks the existing output target file in prior to overwriting it, and avoids unnecessary overwriting if the content is not going to be changed by overwriting.This feature will be used for files of which the cost of unnecessary overwriting is too expensive.