Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that the GroupReadsByUmiTests for marking duplicates are #962

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jan 29, 2024

actually run

The tests did not check for non-empty output, so would pass even if the tool was not being executed

actually run

The tests did not check for non-empty output, so would pass even if the
tool was not being executed
Copy link
Member

@clintval clintval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afa634e) 95.62% compared to head (a4cec0c) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         126      126           
  Lines        7355     7355           
  Branches      528      528           
=======================================
  Hits         7033     7033           
  Misses        322      322           
Flag Coverage Δ
unittests 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 merged commit d85efb9 into main Jan 30, 2024
6 checks passed
@nh13 nh13 deleted the feature/ensure-markdup-tests-are-run branch January 30, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants