Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage example #21

Merged
merged 6 commits into from
May 20, 2024
Merged

Update usage example #21

merged 6 commits into from
May 20, 2024

Conversation

robgodfrey
Copy link
Contributor

Why?

  • Echoing secrets is poor practice, therefore updating examples to not do that.

What?

  • Updated examples to show configuration of npm rather than echoing secret

robgodfrey added 4 commits May 20, 2024 14:18
@robgodfrey
Update usage example
c598295 
Change example to discourage echoing secrets
@robgodfrey
Update use-orb-with-alpine-container example
ed81b97 
Update example to configure npm rather than echo a secret
@robgodfrey
Update use-orb-with-standard-linux-container example
c969a0c 
Update example to configure npm rather than echo secret
@robgodfrey
Update load_secrets_for_multiple_doppler_configs example
ea358fb 
Update example to configure npm rather than echo secret
@robgodfrey robgodfrey requested a review from a team as a code owner May 20, 2024 13:29
Seraph2000
Seraph2000 approved these changes May 20, 2024
View reviewed changes
Copy link

@Seraph2000 Seraph2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

hamza-samih
hamza-samih approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@hamza-samih hamza-samih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, only had echoing secrets as a practical example to showcase that secrets can be transferred over

@robgodfrey robgodfrey merged commit ecb9e4b into main May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seraph2000 Seraph2000 Seraph2000 approved these changes

@hamza-samih hamza-samih hamza-samih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robgodfrey @Seraph2000 @hamza-samih