editor: new Element, MetalWireguide - first RP for review #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freezy
approved these changes
Jan 8, 2022
There was a problem hiding this comment.
Tested, and very awesome stuff!
Thanks a ton for this, it's insane how fast you figured out which of the dozens of new classes you needed to create for a brand new game item.
Apart from adding yourself to the list of contributors and updating the changelog, it's fine for me to merge. Let me know if there's anything else, then I'll merge tomorrow.
Cheers!
|
I‘m fine with merging. Thanks for your kind words. And thanks for helping me with all the git stuff. I‘m happy to help. The new element still needs some love, but it’s Ok for others to try. |
freezy
force-pushed
the
MetalWireGuides
branch
from
e2c57fb to
0f857fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still todo: Thickness should be float,
Standheight not implemented
defaults are a mess (especially the dragpoints)