Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switches for entry switch instead of only kickers. #248

Merged
merged 25 commits into from
Nov 25, 2020

Conversation

freezy
Copy link
Owner

@freezy freezy commented Nov 17, 2020

This needed some refactoring because initially, colliders wouldn't get the ball entity, which is necessary to destroy it.

Also fixed the trough not being imported correctly because it's not renderable anymore.

TODO

  • Check whether we can apply this to all colliders or just keep switches.
  • Update documentation

@freezy freezy added the enhancement New feature or request label Nov 17, 2020
@freezy freezy self-assigned this Nov 17, 2020
@freezy freezy force-pushed the feature/trough-with-switch-entry branch from 7b61153 to d93dac5 Compare November 17, 2020 23:29
@freezy freezy force-pushed the feature/trough-with-switch-entry branch from d93dac5 to 25491a1 Compare November 21, 2020 22:54
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #248 (72567a0) into master (4bff26c) will increase coverage by 0.17%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   56.59%   56.76%   +0.17%     
==========================================
  Files         159      159              
  Lines        9388     9418      +30     
  Branches      930      932       +2     
==========================================
+ Hits         5313     5346      +33     
+ Misses       3856     3848       -8     
- Partials      219      224       +5     
Impacted Files Coverage Δ
VisualPinball.Engine/VPT/Table/Table.cs 49.60% <0.00%> (-0.27%) ⬇️
VisualPinball.Engine/VPT/Trough/Trough.cs 81.13% <88.23%> (+19.59%) ⬆️
VisualPinball.Engine/VPT/Trough/TroughData.cs 96.15% <100.00%> (+0.15%) ⬆️
VisualPinball.Engine/VPT/Mappings/Mappings.cs 77.72% <0.00%> (-1.00%) ⬇️
VisualPinball.Engine/IO/BiffData.cs 89.78% <0.00%> (+5.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bff26c...72567a0. Read the comment docs.

@freezy freezy requested a review from ecurtz November 24, 2020 08:07
@freezy freezy merged commit 57cb41f into master Nov 25, 2020
@freezy freezy deleted the feature/trough-with-switch-entry branch November 25, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants