-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switches for entry switch instead of only kickers. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freezy
force-pushed
the
feature/trough-with-switch-entry
branch
from
November 17, 2020 23:29
7b61153
to
d93dac5
Compare
…ays nicely with Unity Inspector.
freezy
force-pushed
the
feature/trough-with-switch-entry
branch
from
November 21, 2020 22:54
d93dac5
to
25491a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 56.59% 56.76% +0.17%
==========================================
Files 159 159
Lines 9388 9418 +30
Branches 930 932 +2
==========================================
+ Hits 5313 5346 +33
+ Misses 3856 3848 -8
- Partials 219 224 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed some refactoring because initially, colliders wouldn't get the ball entity, which is necessary to destroy it.
Also fixed the trough not being imported correctly because it's not renderable anymore.
TODO