Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cheatcodes): record state diff only if balance changed #9658

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(cheatcodes): record state diff only if balance changed #9658

merged 1 commit into from
Jan 9, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

closes #9656

  • record account only if balance or storage changed

Solution

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Jan 9, 2025
@grandizzy grandizzy marked this pull request as ready for review January 9, 2025 12:49
@grandizzy grandizzy enabled auto-merge (squash) January 9, 2025 12:49
yash-atreya
yash-atreya approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@grandizzy grandizzy merged commit 6cbf390 into foundry-rs:master Jan 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cheatcodes): vm.getStateDiff reports contain addresses without diff
2 participants
@grandizzy @yash-atreya