fix: do not remove snapshots directory before running the test suite

[zerosnacks]

Motivation

Ref: #9477 (comment)

Closes: #9477

Solution

Given the feedback we've received on the default behavior of removing the snapshots directory this PR proposes to remove the removal process all together.

This PR intends to be minimally breaking in terms of end user experience.

The effect is that we no longer automatically clean up for the user if they have made a change in the following:

• A change in the test name
• A change in the custom group name

These files will now be stained and in turn this means it is the responsibility of the user to clean this up.

forge clean will no longer remove the snapshots directory. It is up to the user to manually delete the snapshots directory if they intend on clearing it out entirely.

Reminder that users can configure the snapshots location to whatever folder they like.

Running a single test will still overwrite the individual snapshot file and only write its single entry in.

[zerosnacks]

cc @sakulstra / @smartcontracts

[sakulstra]

Running a single test will still overwrite the individual snapshot file and only write its single entry in.

Do i correctly understand that this would "overwrite the whole file", or would it only overwrite/update the affected lines in the snapshot?
I think the latter would be more consistent in regards to staining.

[zerosnacks]

Running a single test will still overwrite the individual snapshot file and only write its single entry in.

Do i correctly understand that this would "overwrite the whole file", or would it only overwrite/update the affected lines in the snapshot? I think the latter would be more consistent in regards to staining.

It would still overwrite the whole file.

I agree that it would be preferable for individual tests to be merged into existing snapshots (overwriting existing keys, leaving the rest intact). This PR does not change the behavior.

I'll tackle that in a follow-up PR as it requires a bit more consideration in terms of resource locking w/ multiple concurrent tests (as different test suites can write to the same file).