This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
parse credentials without scheme #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the host within the docker config has format IP:PORT url.Parse(host) fails. This commit will first try reparsing with prepended scheme before returning any error.
|
Thanks for this! I'm going to give it a quick go locally, then will review here. |
squaremo
approved these changes
Jul 11, 2019
squaremo
added a commit
that referenced
this pull request
Jul 25, 2019
…heme parse credentials without scheme
squaremo
added a commit
that referenced
this pull request
Jul 25, 2019
…heme parse credentials without scheme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host within the docker config has format IP:PORT
url.Parse(host) fails. This commit will first try re-parsing
with prepended scheme before returning any error.