Lint fixes #10
Merged
Lint fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rules/noFlowFixMeComments.js
Outdated
|
|
||
| const create = (context) => { | ||
| const allowedPattern = context.options[0] ? new RegExp(context.options[0], 'u') : null; | ||
| const extraMessage = allowedPattern ? ' Fix it or match `' + allowedPattern.toString() + '`.' : ''; | ||
| const extraMessage = allowedPattern ? ` Fix it or match \`${allowedPattern.toString()}\`.` : ''; |
There was a problem hiding this comment.
Suggested change
| const extraMessage = allowedPattern ? ` Fix it or match \`${allowedPattern.toString()}\`.` : ''; | |
| const extraMessage = allowedPattern ? ` Fix it or match \'${allowedPattern.toString()}\'.` : ''; |
Maybe instead of a backtick we can use single quotations to match the format of other messages
There was a problem hiding this comment.
btw the test would then need to be updated if it is changed from backticks - this change won't provide much value but we should probably have standards in the error messaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7