Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs with millisecond timestamp #534

Merged
merged 3 commits into from
Jun 20, 2023
Merged

logs with millisecond timestamp #534

merged 3 commits into from
Jun 20, 2023

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Jun 19, 2023

📝 Summary

Add milliseconds to logs time

# before:
2023-06-19T22:42:58+02:00

# after:
2023-06-19T22:44:32.984+02:00

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

avalonche
avalonche previously approved these changes Jun 20, 2023
cli/main.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #534 (75b9d72) into develop (54eeaa2) will decrease coverage by 0.45%.
The diff coverage is 65.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #534      +/-   ##
===========================================
- Coverage    70.24%   69.79%   -0.45%     
===========================================
  Files            6        8       +2     
  Lines          541     1288     +747     
===========================================
+ Hits           380      899     +519     
- Misses         132      340     +208     
- Partials        29       49      +20     
Flag Coverage Δ
unittests 69.79% <65.70%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/main.go 0.00% <0.00%> (ø)
cli/types.go 0.00% <0.00%> (ø)
server/mock_types.go 100.00% <ø> (ø)
server/types.go 70.00% <70.00%> (ø)
server/service.go 77.10% <75.64%> (+5.09%) ⬆️
server/utils.go 82.58% <85.15%> (+15.01%) ⬆️
server/mock_relay.go 88.44% <90.81%> (+5.58%) ⬆️
server/relay_entry.go 90.00% <100.00%> (+8.75%) ⬆️

... and 1 file with indirect coverage changes

@metachris metachris merged commit ff6e260 into develop Jun 20, 2023
@metachris metachris deleted the ms-logs branch June 20, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants