Add retries for get payload #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
π£ This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 67.69% 68.79% +1.09%
==========================================
Files 8 8
Lines 1226 1266 +40
==========================================
+ Hits 830 871 +41
+ Misses 347 345 -2
- Partials 49 50 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
avalonche
commented
Sep 21, 2022
avalonche
commented
Sep 21, 2022
metachris
reviewed
Sep 21, 2022
avalonche
force-pushed
the
add-get-payload-retries
branch
from
efb8d6f to
0e6a53a
Compare
avalonche
force-pushed
the
add-get-payload-retries
branch
from
0e6a53a to
a9aa8ec
Compare
avalonche
force-pushed
the
add-get-payload-retries
branch
from
a9aa8ec to
dcd75c5
Compare
avalonche
force-pushed
the
add-get-payload-retries
branch
from
7a0ee10 to
93106f0
Compare
metachris
reviewed
Mar 7, 2023
metachris
reviewed
Mar 7, 2023
metachris
reviewed
Mar 7, 2023
jtraglia
reviewed
Mar 7, 2023
avalonche
force-pushed
the
add-get-payload-retries
branch
from
a58295d to
eeb0a1b
Compare
avalonche
force-pushed
the
add-get-payload-retries
branch
from
eeb0a1b to
86bffd0
Compare
0xpanoramix
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Resolves issue #323 allowing getPayload to retry the call on errors, as long as it's below the configured timeout
β± Motivation and Context
Improves reliability of the getPayload call
π References
β I have run these commands
make lintmake test-racego mod tidy