subnet/config.go: Fix handling of subnet config #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunjan5
reviewed
Dec 11, 2017
subnet/config.go
Outdated
| // try to give each host a /24 but if the whole network | ||
| // is /24 or smaller, half the network | ||
| // try to give each host a /24 but if the whole network is /24 or smaller, split the network into four. | ||
| // the first subnet isn't used, so splitting into two one only provide one usable host. | ||
| if cfg.Network.PrefixLen < 24 { |
There was a problem hiding this comment.
shouldn't this be <= according to the comment?
There was a problem hiding this comment.
@gunjan5 I updated the comments and code on these lines. PTAL.
Fix all the limits, especially around minimum sizes Fixes flannel-io#696
tomdee
force-pushed
the
fix-subnet-checking
branch
from
2894d74 to
4485ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the limits, especially around minimum sizes
Fixes #696