vendor: remove files not needed for building #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhh, what a great PR - removing 5 million lines of code! Does this need a particular (recent) version of glide? If so, could you add a comment stating that in the Makefile? |
heyitsanthony
force-pushed
the
strip-vendor-tests
branch
from
2320f73 to
59b138b
Compare
added 2 commits
April 19, 2017 09:27
Strips test cases and non-code assets from vendored packages.
|
@tomdee I don't think it needs a bleeding edge version of glide; I suspect the makefile will fail if it's not up to date. I added comments about where to get etcd's deps script goes so far as to force an exact repo revision, but that seemed excessive for what this PR is trying to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
glide vc --only-code --no-testsover the repo. Includes a makefile rule for future use.