Add ali cloud VPC network support #571
Conversation
|
@tomdee @evanfarrar Could you review this? Tks. |
| * Requirements: | ||
| * Running on an ECS instance that is in an Alicloud VPC. | ||
| * Permission require accessid and keysecret | ||
| * `Type` (string): `aws-vpc` |
There was a problem hiding this comment.
The type field is wrong here
| cfg.AccessKeySecret = os.Getenv("ACCESS_KEY_SECRET") | ||
|
|
||
| if cfg.AccessKeyID == "" || cfg.AccessKeySecret == "" { | ||
| return nil, fmt.Errorf("ACCESS_KEY_ID and ACCESS_KEY_SECRET must provide ") |
|
@spacexnice Are you happy to help out with supporting this if users hit problems? |
|
@tomdee Tks, Yes,We are happy to help out with supporting! Please do not hesitate to contact us. |
|
@spacexnice Excellent. Before I merge, it would be great to have a guide or something for this, similar to /~https://github.com/coreos/flannel/blob/master/Documentation/aws-vpc-backend.md would you be able to add that? |
|
@tomdee Add a AliCloud VPC flannel Guide at Documentation directory. Pls review it . |
| beta.kubernetes.io/arch: amd64 | ||
| containers: | ||
| - name: kube-flannel | ||
| image: registry.cn-hangzhou.aliyuncs.com/google-containers/flannel-git:v0.6.2-ubuntu |
There was a problem hiding this comment.
Can you change this to quay.io/coreos/flannel:v0.7.0
| - name: ACCESS_KEY_ID | ||
| value: [replace with your own key] | ||
| - name: ACCESS_KEY_SECRET | ||
| value: [replaces with your own secret] |
| - name: flannel-cfg | ||
| mountPath: /etc/kube-flannel/ | ||
| - name: install-cni | ||
| image: registry.cn-hangzhou.aliyuncs.com/google-containers/flannel-git:v0.6.2-ubuntu |
There was a problem hiding this comment.
Change to quay.io/coreos/flannel:v0.7.0
There was a problem hiding this comment.
Because this driver is intended to be used on alibaba cloud env, and mostly for china users , BUT quay.io/coreos is behind china's great firewall which we can not access directly, So we need to mirror quay.io ourselves. On the other hand, we can add another yaml file call kube-flannel-alivpc-quay.yml for out of china purpose. and keep the old one. Or do you have any other suggestion? @tomdee Thanks!
There was a problem hiding this comment.
OK, could you at least update it to the 0.7.0 release (without the -git suffix)
|
@spacexnice looks good. Can you just change the the images to be the official 0.7.0 release? |
Signed-off-by: yaoyao.xyy <yaoyao.xyy@alibaba-inc.com>
|
updated. @tomdee |
|
Merging! |
Add ali cloud VPC network driver
Add an ali-vpc backend which made flannel available on Alibaba cloud VPC network.
see README.md for ali-vpc backend configuration.
Signed-off-by: yaoyao.xyy yaoyao.xyy@alibaba-inc.com