Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify leases code #1773

Merged
merged 1 commit into from
May 29, 2023
Merged

Simplify leases code #1773

merged 1 commit into from
May 29, 2023

Conversation

manuelbuil
Copy link
Collaborator

@manuelbuil manuelbuil commented May 18, 2023 •
edited
Loading

Description

  • Remove duplicate code by creating the "sameSubnet" function
  • Removes deleteLease function which was not used anywhere

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Simplify leases code

@manuelbuil
Simplify leases code
a31c2c9 
Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil mentioned this pull request May 29, 2023
Closed
3 tasks
@manuelbuil manuelbuil merged commit b8cee0a into flannel-io:master May 29, 2023
@manuelbuil manuelbuil deleted the simplifyLeases2 branch May 29, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelbuil @rbrtbnfgl @thomasferrandiz