Updated documentation #1687
Merged
Updated documentation #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
thomasferrandiz
approved these changes
Dec 9, 2022
manuelbuil
requested changes
Dec 11, 2022
| @@ -33,7 +33,7 @@ Flannel can be added to any existing Kubernetes cluster though it's simplest to | |||
|
|
|||
| For Kubernetes v1.17+ | |||
| ``` | |||
| kubectl apply -f https://raw.githubusercontent.com/flannel-io/flannel/master/Documentation/kube-flannel.yml | |||
| kubectl apply -f https://raw.githubusercontent.com/flannel-io/flannel/v0.20.2/Documentation/kube-flannel.yml | |||
There was a problem hiding this comment.
I think it makes more sense to leave it as master, otherwise we will need to change this line in each release, or?
There was a problem hiding this comment.
We need to change it on each release, but if there are delay on the publishing of the image the documentation is pointing on a not working manifest. I didn't find a way to point to the latest release.
There was a problem hiding this comment.
What about using the tag latest in the manifest?
Co-authored-by: Manuel Buil <mbuil@suse.com>
manuelbuil
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md to point to the latest release manifest (#1685) and fixed build status link to point github workflow instead of travis old reference.
Updated IPv6 only documentations (#1674)