-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MultiClusterCIDR feature in flannel #1658
Merged
thomasferrandiz
merged 1 commit into
flannel-io:master
from
thomasferrandiz:useClusterCIDRConfig
Dec 13, 2022
Merged
Implement MultiClusterCIDR feature in flannel #1658
thomasferrandiz
merged 1 commit into
flannel-io:master
from
thomasferrandiz:useClusterCIDRConfig
Dec 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
2 times, most recently
from
November 9, 2022 15:49
8595efa
to
e425a3d
Compare
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
from
November 10, 2022 09:57
e425a3d
to
c10637d
Compare
thomasferrandiz
changed the title
Use cluster cidr config
Implement MultiClusterCIDR feature in flannel
Nov 10, 2022
manuelbuil
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are so many changes to understand in once all the changes :)
rbrtbnfgl
requested changes
Nov 14, 2022
manuelbuil
requested changes
Nov 16, 2022
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
from
November 28, 2022 08:53
8d6bf69
to
1254a94
Compare
rbrtbnfgl
reviewed
Nov 28, 2022
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
4 times, most recently
from
December 5, 2022 15:11
1c92fa1
to
009178b
Compare
rbrtbnfgl
reviewed
Dec 5, 2022
manuelbuil
reviewed
Dec 5, 2022
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
3 times, most recently
from
December 12, 2022 09:02
a3c0029
to
f72e7fd
Compare
This API requires Kubernetes 1.26 and is available for vxlan, wireguard and host-gw backends. Signed-off-by: Thomas Ferrandiz <thomas.ferrandiz@suse.com>
thomasferrandiz
force-pushed
the
useClusterCIDRConfig
branch
from
December 12, 2022 09:23
f72e7fd
to
243cf7e
Compare
rbrtbnfgl
approved these changes
Dec 12, 2022
manuelbuil
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Thomas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the MultiClusterCIDR feature as requested in #1564.
It was tested manually with Kubernetes 1.26-alpha.1.
At the moment, it is optional and is activated via a flag when starting flannel.
Todos
Release Note