Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI problem: Save Path is very squashed (on two different Linux PCs) #1726

Closed
LinuxOnTheDesktop opened this issue Jul 20, 2021 · 6 comments
Closed

UI problem: Save Path is very squashed (on two different Linux PCs) #1726

LinuxOnTheDesktop opened this issue Jul 20, 2021 · 6 comments
Labels
Bug It's a bug Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.

Comments

@LinuxOnTheDesktop
Copy link

LinuxOnTheDesktop commented Jul 20, 2021 •
edited
Loading

Flameshot version
0.9.0
Compiled with QT 5.11.3

Describe the bug

On one of my computers [EDIT: a ThinkPad X230, resolution 1366x768, with no Hi-DPI scaling], I see this:

image

On another of my computers [EDIT: a ThinkPad X1CG6, resolution 2560x1440 , with 2x Hi-DPI scaling for GTK and with QT_AUTO_SCREEN_SCALE_FACTOR=1], I see this:

image

To Reproduce
Open the relevant configuration pane.

Expected behavior
Obviously, the 'Save Path' part of the configuration file should be readable.

System Information
Both computers are ThinkPads running Linux Mint Cinnamon on a 5.8 kernel. EDIT: for further information, please see above.
@LinuxOnTheDesktop LinuxOnTheDesktop mentioned this issue Jul 20, 2021
Closed
@borgmanJeremy
Copy link
Contributor

Can you post your resolution? I'll fire up a mint VM, guessing it's cinnamon related.

@borgmanJeremy
Copy link
Contributor

Btw which thinkpads? I have a x230 I could test on

@LinuxOnTheDesktop
Copy link
Author

Thank you.

I have updated my first post with the necessary information.

@mmahmoudian
Copy link
Member

@borgmanJeremy the squashed effect looks a lot like the #1697, hence they might be related or get solved together.

@borgmanJeremy
Copy link
Contributor

Yup, I can confirm this issue on setups with small vertical resolutions. The solution will be to embed all the settings in a vertical scroll bar.

I never noticed it on my x230 because it runs i3 which maximizes the vertical space enough. I replicated it in a VM and by installing plasma on my x230.

@borgmanJeremy borgmanJeremy added Bug It's a bug Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed. labels Jul 25, 2021
@veracioux veracioux mentioned this issue Jul 29, 2021
Closed
borgmanJeremy pushed a commit that referenced this issue Jul 31, 2021
@veracioux
Fix #1697 and #1726 (#1782)
8ba06b7 
* Fix #1697 and #1726

Changed ConfigWindow to inherit QWidget and moved QTabWidget to be an
attribute. setMinimumSize is no longer necessary in ConfigWindow.

Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>

* Create scroll area around checkboxes

Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>

* Do not truncate tab bar anymore

Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>

* Set parent widget to prevent a memory leak

Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>
@veracioux
Copy link
Contributor

@borgmanJeremy I think this issue can be closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug It's a bug Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mmahmoudian @veracioux @borgmanJeremy @LinuxOnTheDesktop