embeddings: fix attention mask for special Transformer architectures #2485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
special architectures such as the recently introduced FNet do not provide an
attention_mask
for the model forward pass.This would cause the following error, that can be reproduced with the official NER example script:
$ cd examples/ner $ python3 run_ner.py --dataset_name WNUT_17 --model_name_or_path google/fnet-base --output_dir wnut-fnet-base-baseline --num_epochs 1
Outputs:
This PR fixes this, so that FNet - and other potential architectures that do not have an
attention_mask
- can be used in Flair.Notice: I did also compare the model fine-tuning result before and after the PR with a DistilBERT model, to make sure that this doesn't introduce any regression. Tested with: