Bugfix/budget association issue 21 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fivetran-sheringuyen
changed the base branch from
main
to
MagicBot/dbt-utils-cross-db-migration
CHANGELOG.md
Outdated
| @@ -37,6 +37,9 @@ | |||
| - `dbt.current_timestamp_in_utc_backcompat` | |||
| - `packages.yml` has been updated to reflect new default `fivetran/fivetran_utils` version, previously `[">=0.3.0", "<0.4.0"]` now `[">=0.4.0", "<0.5.0"]`. | |||
|
|
|||
| [PR #22](/~https://github.com/fivetran/dbt_microsoft_ads/pull/22) includes the following updates: | |||
| - Added `budget_association_status` into the `stg_microsoft_ads__campaign_daily_report` table in order to account for campaign budgets that end midday. Including `budget_association_status` as another grain to test by, will reduce tests failing due to non-uniqueness of rows. This change will therefore yield an update this package's `integration_tests/seeds/microsoft_ads_campaign_performance_daily_report_data`. | |||
There was a problem hiding this comment.
should we note that this change only really affects the source package and not the final campaign report model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Fivetran Employee
What change(s) does this PR introduce?
budget_association_statusinto thestg_microsoft_ads__campaign_daily_reporttable in order account for campaign budgets that end midday. Includingbudget_association_statusas another grain to test by, will reduce tests failing due to non-uniqueness of rows. This change will therefore yield an update this package'sintegration_tests/seeds/microsoft_ads_campaign_performance_daily_report_data.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.