Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnemonic updates #772

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Mnemonic updates #772

merged 1 commit into from
Nov 27, 2019

Conversation

riordant
Copy link
Contributor

  • add usemnemonic conf setting, on by default (as we have with usehd). this allows us to create non-mnemonic wallets and block key imports to mnemonic wallets
  • remove code that creates new master key for non-mnemonic wallets

levonpetrosyan93
levonpetrosyan93 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenyap reubenyap requested a review from a-bezrukov November 27, 2019 01:38
@riordant riordant merged commit 7651f5b into mnemonic Nov 27, 2019
@riordant riordant deleted the mnemonic-updates branch November 27, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

@a-bezrukov a-bezrukov Awaiting requested review from a-bezrukov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riordant @levonpetrosyan93