Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to lock Glibc to 2.17 on gnu targets #34

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Attempt to lock Glibc to 2.17 on gnu targets #34

merged 3 commits into from
Aug 10, 2022

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Aug 10, 2022 •
edited
Loading

cross-rs strikes again! Looks like all the fine and dandy zig builds did not build against the glibc version specified.

Trying a more specific selector.

@jamilbk jamilbk added the bug Something isn't working label Aug 10, 2022
@jamilbk jamilbk mentioned this pull request Aug 10, 2022
Merged
@jamilbk jamilbk requested a review from akrousset August 10, 2022 20:14
@jamilbk jamilbk self-assigned this Aug 10, 2022
@jamilbk
Copy link
Member Author

jamilbk commented Aug 10, 2022

Screen Shot 2022-08-10 at 12 36 50 PM

@jamilbk
Copy link
Member Author

jamilbk commented Aug 10, 2022

@akrousset I think this will fix the firezone build so we can release 0.5.3.

@akrousset
Copy link
Contributor

akrousset commented Aug 10, 2022 •
edited
Loading

Cool, looks good to me. I used objdump -T <lib> | grep GLIBC to be sure that they're linked with the proper glibc.

@jamilbk
Copy link
Member Author

jamilbk commented Aug 10, 2022

Cool, looks good to me. I used objdump -x <lib> | grep GLIBC to be sure that they're linked with the proper glibc.

Sweet, I was about to ask if you had any ideas on that before we cut a new release.

@jamilbk jamilbk merged commit 2db0d36 into main Aug 10, 2022
@jamilbk jamilbk deleted the glibc-lock branch August 10, 2022 20:59
@akrousset
Copy link
Contributor

For aarch64:

└─ λ objdump -T libwireguard_nif-v0.3.4-nif-2.14-aarch64-unknown-linux-gnu.so | grep GLIBC
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  free
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  memcpy
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  malloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  posix_memalign
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  strlen
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  realloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  bcmp
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  __xpg_strerror_r
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_mutex_unlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  close
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  memset
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  socket
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  connect
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  send
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  memmove
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  __errno_location
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  syscall
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_mutex_lock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  open64
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  poll
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  read
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  abort
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_getspecific
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_setspecific
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_key_create
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_key_delete
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  clock_gettime
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  write
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  readlink
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  munmap
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  mmap
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  realpath
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  calloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  getcwd
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  dl_iterate_phdr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  getenv
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  recv
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  unlink
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  getauxval
0000000000000000      DO *UND*  0000000000000000  GLIBC_2.17  stderr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  fprintf
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  fflush
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_rwlock_wrlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_rwlock_unlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  dladdr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  snprintf
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  pthread_rwlock_rdlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  fwrite

For x86_64:

└─ λ objdump -T libwireguard_nif-v0.3.4-nif-2.14-x86_64-unknown-linux-gnu.so | grep GLIBC
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 free
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.14  memcpy
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 malloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 posix_memalign
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 strlen
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 realloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 bcmp
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_mutex_unlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 close
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.3.4 __xpg_strerror_r
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 memmove
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 memset
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 socket
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 connect
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 send
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 __errno_location
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 syscall
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_mutex_lock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 open64
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 poll
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 read
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 abort
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.3   __tls_get_addr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_getspecific
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_setspecific
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_key_create
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_key_delete
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.17  clock_gettime
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 write
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 readlink
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 munmap
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 mmap
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.3   realpath
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 calloc
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 getcwd
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 dl_iterate_phdr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 getenv
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 recv
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 unlink
0000000000000000      DO *UND*  0000000000000000  GLIBC_2.2.5 stderr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 fprintf
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 fflush
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_rwlock_wrlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_rwlock_unlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 dladdr
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 snprintf
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 pthread_rwlock_rdlock
0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 fwrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrousset akrousset akrousset approved these changes

Assignees

@jamilbk jamilbk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamilbk @akrousset