Reset dirty bitmap on Full Snapshot #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackThomson2
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
+ Coverage 82.03% 82.04% +0.01%
==========================================
Files 253 253
Lines 31049 31072 +23
==========================================
+ Hits 25470 25492 +22
- Misses 5579 5580 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The commit |
When a diff snapshot it taken, it always contains all pages that were dirtied since either instance start, or since the last diff snapshot was taken, whichever is more recent. This is not what we document it to do: > the diff consists of the memory pages which have been dirtied since > the last snapshot creation or since the creation of the microVM, > whichever of these events was the most recent. Here "last snapshot creation" includes full snapshots, not just diff snapshots (and that makes sense, if I take a diff snapshot after a full snapshot, I expect the diff snapshot to be a diff compared to the full snapshot). Signed-off-by: Jack Thomson <jackabt@amazon.com> Co-authored-by: Roman Kovtyukh <HelloDearGrandma@gmail.com> Co-authored-by: Muskaan Singla <msinglaa@amazon.com>
Test that taking full snapshot is as described in documentation: > the diff consists of the memory pages which have been dirtied since > the last snapshot creation or since the creation of the microVM, > whichever of these events was the most recent. Signed-off-by: Jack Thomson <jackabt@amazon.com> Co-authored-by: Roman Kovtyukh <HelloDearGrandma@gmail.com> Co-authored-by: Pablo Barbáchano <pablob@amazon.com>
Changed to reset internal firecracker bitmap when creating a full snapshot. Signed-off-by: Jack Thomson <jackabt@amazon.com> Co-authored-by: Roman Kovtyukh <HelloDearGrandma@gmail.com> Co-authored-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
added
Priority: Low
pb8o
added
Status: Awaiting review
roypat
approved these changes
Apr 9, 2024
pb8o
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A continuation of the pr here #4385
The changes are:
Reason
Vmm:get_dirty_bitmapthus doesn’t callKVM_GET_DIRTY_LOGwhich doesn’t reset dirty pages.Closes #4543.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.