Ssrc targeting numeric version fixes #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikeldridge
approved these changes
Jul 31, 2024
| @@ -293,6 +293,9 @@ function compareNumbers( | |||
| return predicateFn(actual < target ? -1 : actual > target ? 1 : 0); | |||
| } | |||
|
|
|||
| // Max number of segments a numeric version can have. This is enforced by the server as well. | |||
| const MAX_LENGTH = 5; | |||
There was a problem hiding this comment.
Thinking: five segments deviates from the semver spec, but consistency w the backend is more important, since RC is cross-platform.
kjelko
added a commit
that referenced
this pull request
Aug 20, 2024
* refactor numeric version parsing logic and add more test cases * run lint * test cases for max num segments * run lint on tests --------- Co-authored-by: Kevin Elko <kjelko@google.com>
kjelko
added a commit
that referenced
this pull request
Sep 5, 2024
* Initial set up and evaluation logic for server side custom signals (#2628) initial skeleton for custom signal evaluation logic --------- Co-authored-by: Kevin Elko <kjelko@google.com> * Add logic for remaining custom signal operators (#2633) * initial skeleton for custom signal evaluation logic * adjust some formatting * remove extra curly brace * run lint * Run apidocs * Split EvaluationContext into UserProvidedSignals and PredefinedSignals * rerun apidocs * add logic for remaining custom signal operators * more test cases * test cases for numeric operators * update tests to be way more robust and implement handling for a few edge cases * update some comments --------- Co-authored-by: Kevin Elko <kjelko@google.com> * Ssrc targeting numeric version fixes (#2656) * refactor numeric version parsing logic and add more test cases * run lint * test cases for max num segments * run lint on tests --------- Co-authored-by: Kevin Elko <kjelko@google.com> * fix test ordering * Export signal types and rerun apidocs * update docstrings * uber minor comment fix --------- Co-authored-by: Kevin Elko <kjelko@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address minor bug fixes in numeric version handling