Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check in tipset change handler #3011

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add nil check in tipset change handler #3011

merged 1 commit into from
Aug 12, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Aug 12, 2020

Summary

Add a check for nil tipsets in the storage provider adapter.

Didn't fix the root issue (maybe a race?) as to why we are getting nils back from the tipSetCache.best().

Resolves #2865

@whyrusleeping whyrusleeping requested a review from magik6k August 12, 2020 21:44
magik6k
magik6k approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's better than crashing

@magik6k magik6k merged commit 4308d37 into next Aug 12, 2020
@magik6k magik6k deleted the fix/nil-tipset-storageprovider branch August 12, 2020 22:04
This was referenced Sep 4, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingar @magik6k