Remove escape chars on input columns #14903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both, the
TextInputColumn
andSelectColumn
have an<input type="hidden" x-ref="newState>
field.This field stores the current state but escapes the
double quote
character with abackslash
.When the
TextInputColumn
contains double quotes and gets stored, the field renders the escape characters in the browser. On the next update, the escape characters also gets stored in the db.Also, if someone decides to use the
SelectColumn
with an options key containing adouble quote
, that option cannot be selected.I wasn't able to inject the
double quote
char without breaking thex-init=""
attribute, so I usedString.fromCharCode(34)
instead. Maybe there is better solution.Visual changes
composer cs
command.