-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for AWS ELB. Accept IPs separated by comma. #117
Conversation
rrpadilla
commented
Dec 9, 2018
- Accept IPs separated by comma.
- Probably In a project like Laravel you need to add this config to the .env file and array is not supported in .env
- Accept headers as a string.
- Probably In a project like Laravel you need to add this config to the .env file and you can pass the header you want to use as a string:
Hi, |
Hi @fideloper, Thanks. |
Hi @fideloper, Thanks. |
I will eventually look into this, yes! My first pass at it looks good, I like supporting it as something coming from the .env file as well. If you have time, could you add a test or two to ensure it's reading text-based configurations and converting it correctly? |
Hi @fideloper, Thanks. |
…ting it correctly.
Hi @fideloper, Could you confirm? Thanks. |
Thanks! I'm getting a 2nd pair of eyes on it to make sure I didn't miss anything since it will end up in Laravel installations by default. |
Hi @fideloper, Thanks. |
Pulled it in, thanks! @rrpadilla it sounded like you wanted to see if you could get a PR into Laravel, correct? Do you want to do that before I make a release out of this? I'll likely make it 4.1 (current is 4.0.0) since I don't believe it's a breaking change. |
@fideloper I like that idea. |
@fideloper You can check Laravel PR here Thanks. |