Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits #120

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Minor edits #120

merged 4 commits into from
Oct 2, 2024

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Sep 30, 2024

  • why do we split things into files here (only?)
  • Is it worth talking about why we choose the order we do in the algothrithm in 4.x?
  • in L62 of simple-db.m:
  1. Empty payloads are allowed. In this case, the command is
    PUBLISH \n.

Does this mean if the payload is emppty the command is determined to be PUBLISH. Or does it mean that only PUBLISH can have an empty payload.

@plaindocs plaindocs marked this pull request as ready for review September 30, 2024 11:00
@jonathanpallant
Copy link
Member

why do we split things into files here (only?)

Do you mean the exercise text?

@plaindocs
Copy link
Contributor Author

why do we split things into files here (only?)

Do you mean the exercise text?

Yep, sorry. It's mostly just a consistency thing, along with things like headings of Help, Knowledge, or whether solutions are shown with a reveal or inline.

@jonathanpallant
Copy link
Member

written by different people at different times :/

@plaindocs
Copy link
Contributor Author

Yep, absolutely. If you're keep we could define the structure we want to adhere to, and possibly lint it or just spend some time manually making the older ones match the current format. But it's probably not bang for buck right now.

Co-authored-by: Jonathan Pallant <jonathan.pallant@ferrous-systems.com>
@jonathanpallant
Copy link
Member

Does this mean if the payload is emppty the command is determined to be PUBLISH. Or does it mean that only PUBLISH can have an empty payload.

PUBLISH is the only command that can have a payload - there are only two commands and the other command does not take a payload. But I guess it should be "Sending a PUBLISH with an empty payload is allowed. In this case the command..."

@jonathanpallant jonathanpallant merged commit ada1c61 into ferrous-systems:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants