Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits / catch-all questions #119

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Minor edits / catch-all questions #119

merged 2 commits into from
Oct 2, 2024

Conversation

plaindocs
Copy link
Contributor

  • Slight expectation mismatch, not sure if relevant. I expected to be writing code to parse urls, not outsourcing that to url::Url - perhaps we can tweak the intro in that direction?

Looking at 102, I'm not quite sure what we're saying about the catch all

  • Catch all isn't required
  • What do we mean by placeholder also?

Are we saying you can use specific options, and a catch all even if it does nothing?

@jonathanpallant jonathanpallant merged commit 21b2807 into ferrous-systems:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plaindocs @jonathanpallant