Resolves 1892: compute view factor for rht #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lberti
commented
Feb 15, 2023
•
lberti
commented
- View factor computation via raytracing is performed.
- Two test cases on a cubic and cylindrical cavity are proposed: checks on view factors summing to 1 and comparison with analytical solutions are performed
- Test cases for view factors with quadrature rules have been updated and separated from raytracing ones.
- A Bounding Volume Hierarchy structure is used, and an elementary stackless raytracing algorithm is implemented, as proposed in
- closes Compute ray tracing view factor for RHT #1892
- closes add nanoflann to feelpp #1893
- Bounding Volume Hierarchy tree (one leaf per elem) - Stackless traversal algorithm
- tests for cubic and cylindrical cavities - view factor computation via raytracing
- up new tests for view factor computation
- multithreading for raytracing view factor computation - Nthreads in the json skip toolboxes skip mor skip python
- increase threads and ray number skip toolboxes skip python skip mor
- Nanoflann is no longer needed for the computation of view factors with raytracing - remove the files in tools/view_factor: the current implementation of raytracing is in feel/feelviewfactor skip toolboxes skip mor skip python
Requirements before resolving 1892: compute view factor for rht
prudhomm
requested changes
Feb 27, 2023
skip feelpp skip toolboxes skip tests skip python skip mor
skip feelpp skip toolboxes skip mor skip tests skip python
skip toolboxes skip mor skip python
|
@prudhomm I have made the required changes and the test suite is completed successfully |
prudhomm
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.