Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition for prefixed routes #39

Closed
sinedied opened this issue Mar 9, 2017 · 4 comments
Closed

Definition for prefixed routes #39

sinedied opened this issue Mar 9, 2017 · 4 comments

Comments

@sinedied
Copy link
Contributor

sinedied commented Mar 9, 2017

All my services are versioned and available under the /api/{version}/ prefix.

I'm trying to create definition for my services, but they all end up in the api swagger group, is there a way to prevent this?

@daffl
Copy link
Member

daffl commented Mar 10, 2017

Not at the moment I think. One fix would be to add a config.prefix and then in /~https://github.com/feathersjs/feathers-swagger/blob/master/src/index.js#L65 set something like path = ${config.prefix}/${path}`

@sinedied
Copy link
Contributor Author

At least do you know if it's possible to override the api group during the definition settings? That would be an acceptable workaround.

@daffl
Copy link
Member

daffl commented Mar 14, 2017

Why not a pull request that adds what I suggested?

@sinedied
Copy link
Contributor Author

Why not a pull request that adds what I suggested?

Because it will not work when different prefix are used for services (like /api/v1 and /api/v2) which is the primary point of versioning 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants