Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct RxJS dependency and have it passed to the plugin #12

Merged
merged 1 commit into from
May 23, 2016

Conversation

daffl
Copy link
Member

@daffl daffl commented May 22, 2016

That way you can use RxJS whichever way you want, it removes the hard dependency on RxJS and gets the (unminified) Browserified size down from 550k to 25k. The only thing you have to do now is pass it to the rx method when configuring:

import RxJS from 'rxjs';

app.configure(rx(RxJS, options));

@Harangue Let me know if you see an issue with this.

@jack-guy
Copy link
Contributor

None whatsoever. You want to support any other libraries like Bacon in the short term? We also may want to rebrand since rx is associated with the rx-language set of libraries. Feathers-reactive, perhaps?

@daffl
Copy link
Member Author

daffl commented May 23, 2016

Cool. I'm not sure if the FRP library we use matters too much and if it would be worth the effort. RxJS seems pretty solid (although the new version was a little confusing at first).

I was thinking about rebranding, too. The more I think about it the more I like feathers-reactive. I was thinking of having something less FRP related like feathers-feeds or feathers-observe since people were asking about subscription and changefeeds but reactive is still the most fitting term.

@daffl daffl merged commit d205ad6 into master May 23, 2016
@daffl daffl deleted the configurable-rxjs branch May 23, 2016 06:19
@daffl daffl removed the in progress label May 23, 2016
@daffl
Copy link
Member Author

daffl commented May 24, 2016

@Harangue I renamed to feathers-reactive and published the new version that takes RxJS as a separate argument. Do you have an npm account I can add as a collaborator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants