-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom data sources #1713
Add custom data sources #1713
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
…a_source.py Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
fba75cb
to
6679e05
Compare
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
+ Coverage 84.45% 84.47% +0.01%
==========================================
Files 79 79
Lines 7012 7071 +59
==========================================
+ Hits 5922 5973 +51
- Misses 1090 1098 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just waiting for merge conflict to be resolved. Otherwise lgtm. |
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
What this PR does / why we need it:
After allowing for custom online stores and offline stores, we need to update the DataSource API so that implementors can create custom. DataSources to be used in their feature repo, and provide a mechanism through which these DataSources can be serialized/deserialized from the registry.
This is done by introducing a super simple
CustomSourceOptions
message that contains information about the class used for the source, and any serialized contents. Implementors are responsible for defining ato_proto
andfrom_proto
method and they can serialize the contents into this class as they need.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: