Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当 commit_code 时，输入预览没有清空 #83

Closed
Victrid opened this issue Dec 10, 2023 · 1 comment
Closed

当 commit_code 时，输入预览没有清空 #83

Victrid opened this issue Dec 10, 2023 · 1 comment

Comments

@Victrid
Copy link

Victrid commented Dec 10, 2023 •
edited
Loading

描述错误

当发出 commit_code 时，输入预览没有清空。

librime上的相同issue rime/librime#761 指出这可能是一个fcitx5-rime的问题。因为在Arch Linux上，下文中的测试所使用的librime版本均为1.9.0。

重现
重现错误的步骤

  1. 将patch.ascii_composer.switch_key.Shift_L设置为commit_code。
  2. 输入内容，按 Shift_L 上屏并进入 ascii 模式
  3. 输入预览区仍在显示，没有清空
  4. 按下另一个键，输入的字符丢失

预期行为
不应继续显示输入预览。

屏幕截图

2023-11-13.15-39-39.mp4

软件包：

附加背景
这可能是一个回归问题。这些软件包是从 Arch Linux 安装的，使用 librime 1:1.9.0-1。

fcitx5 fcitx5-rime 有此问题？
5.1.1-1 5.1.2-1 没有
5.1.4-1 5.1.3-1 是
5.1.5-1 5.1.3-1 是

其他Issue #82 也提出类似现象但可能不相同的问题。如果是openSUSE Tumbleweed，则应该对应的是fcitx5-rime 5.1.2和librime 1.8.5。 在该issue中，指出同样使用 fcitx-rime 5.1.3 / librime 1.9.0
@wengxt
Copy link
Member

wengxt commented Dec 10, 2023

#82

把预编辑选项修改一下。
因为改名的缘故选项可能重置了，导致触发了这个，但本质应该是librime的bug

@wengxt wengxt closed this as completed Dec 10, 2023
@Rongronggg9 Rongronggg9 mentioned this issue Apr 28, 2024
Closed
wengxt added a commit that referenced this issue Apr 29, 2024
@wengxt
Always update ClientPreedit
4c7cf16 
The submode update hack actually doesn't clear client preedit on key
release. If we don't reset it to empty, it may be kept.

Fix #82 #83
Closes #100
mokapsing pushed a commit to mokapsing/fcitx5-rime that referenced this issue Apr 30, 2024
@wengxt @mokapsing
Always update ClientPreedit
5af8781 
The submode update hack actually doesn't clear client preedit on key
release. If we don't reset it to empty, it may be kept.

Fix fcitx#82 fcitx#83
Closes fcitx#100
wxyzh pushed a commit to wxyzh/fcitx5-rime that referenced this issue May 13, 2024
@wengxt
Always update ClientPreedit
142be53 
The submode update hack actually doesn't clear client preedit on key
release. If we don't reset it to empty, it may be kept.

Fix fcitx#82 fcitx#83
Closes fcitx#100
wxyzh pushed a commit to wxyzh/fcitx5-rime that referenced this issue Dec 12, 2024
@wengxt
Always update ClientPreedit
25c2bd4 
The submode update hack actually doesn't clear client preedit on key
release. If we don't reset it to empty, it may be kept.

Fix fcitx#82 fcitx#83
Closes fcitx#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wengxt @Victrid