Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run black formatter on config_parser_util.py and valve_lldp.py #4267

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

anarkiwi
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 94.29% and no project coverage change.

Comparison is base (7906bae) 92.26% compared to head (a9ed00f) 92.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4267   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          47       47           
  Lines        8909     8909           
=======================================
  Hits         8219     8219           
  Misses        690      690           
Impacted Files Coverage Δ
faucet/config_parser_util.py 91.82% <89.47%> (ø)
faucet/valve_lldp.py 96.34% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gizmoguy
Copy link
Member

I do enjoy all the white space formatting changes, I think it makes parts of the code easier to read.

The one thing I'm wondering about is all the quotation mark changes. Here is the black documentation on why they picked double quotes for everything:

https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings

They mention the --skip-string-normalization option, if people aren't too fussed on single / double quotes, I wonder if we set this option to skip changing them all? Thoughts?

@anarkiwi anarkiwi merged commit 4122477 into faucetsdn:main Mar 28, 2023
@anarkiwi anarkiwi deleted the black2 branch March 28, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants