Better co-ordination of multiple controllers #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwutzke
commented
Aug 11, 2021
mwutzke
commented
- Ensure individual controllers start the first time, but using unique resources were required
- Change the setup sequencing to ensure all controllers are running at the time the network is started
This will stop multiple Faucet instances trying to create the same listening sockets, of which only instance 1 will succeed. All the others will fail, causing a timeout / retry to occur.
Recent failures with some of the CI testing has highlighted
startup sequencing concerns with multiple Faucet controllers.
Taking a fresh look at the implementation, some optimizations
and consolidations can be made:
- ensure unique Event and Prometheus sockets (previous commit)
- perform all the loop-invariant setup outside of the loop
- ensure the Faucet/Gauge controllers are only started once
for each instance required
- re-use these controllers within the test suite if there is
a problem creating the Mininet environment
- ensure that all the controllers are started before starting
the Mininet environment so that they all see the same
sequence of events, when Mininet hosts start to join
This involves some refactoring of the existing logic, so that
operations / data structures local to _start_faucet() are all
managed within the method.
…aucetsdn#3925)" This reverts commit c80441a. Now that multiple controllers are starting up in sequence once more, the test work-around can be removed.
The location where this is invoked has changed, and the details about the Mininet topology are no longer known. Generally these overloaded methods can be refactored to: - perform the operation during the test phase, or - use the pre_start_net() hook
mwutzke
changed the title
mwutzke
changed the title
anarkiwi
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.