Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments #24

Open
fathomssen opened this issue May 27, 2016 · 10 comments
Open

Add comments #24

fathomssen opened this issue May 27, 2016 · 10 comments
Assignees
Milestone

Comments

@fathomssen
Copy link
Owner

Add a text field to write comments which will be appended to the issue.

@Warlib1975
Copy link

It's really quite important thing when a developer or a tester ad some comment when they finish do the job.

@TyRoden
Copy link

TyRoden commented Jul 21, 2017

I have to agree.. time entries with no comments make this nearly unusable for us.. this is a great tool and would like to use it.

@fathomssen
Copy link
Owner Author

Where would you suggest the comment field should be? Right beneath the timer, above the activity selection?

@TyRoden
Copy link

TyRoden commented Jul 22, 2017 via email

@fathomssen
Copy link
Owner Author

Sounds reasonable. What about the case when you (like I) use keyboard shortcuts most of the time?

Should the last value of the comment field be used (does that even make sense?) or should the comment field be left empty?

Or should you get a pop-up window asking you for a comment? This might not work properly in environments with multiple desktops (you simply would not notice the new window).

@Warlib1975
Copy link

I think comment field should be empty. The process are:

  1. Developer turn on the timer.
  2. When he has finished the job, he writes comments and stop timer.
  3. It would be good if it was possibility to stop timer, then write comment and save it. Just for any case, if developer forgot the sequence.

Comment window may be instead of issue description. E.g. when timer is started description tab switched to comment tab.

I believe that there is no any additional pop-up window, since comment - it's not obliging field.

@fathomssen
Copy link
Owner Author

There is no easy way to amend a time booking after it has been sent to Redmine. So it will be required to enter the comment before stopping the timer.

I would suggest the following implementation:

  1. There will be a new configuration option in the settings dialog that specifies whether a comment is mandatory.
  2. If the comment is NOT mandatory, it MAY be typed into the comment fields and will be saved. If it is left empty, that's OK as well.
  3. If the comment IS mandatory and it has not been specified in the comment field, a message will pop up upon stopping the timer. The timer will continue to count until a comment has been specified and the timer has been stopped again.

What do you think about this approach?

Best regards
Frederick Thomssen

@Warlib1975
Copy link

I believe it's a good decision. :-)

@TyRoden
Copy link

TyRoden commented Jul 24, 2017 via email

@kristian-b
Copy link

Adding a comment is very important for me too. Would be great if that would be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants