Adding support for snippet update #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests look sad on Travis. Did you commit the interactions? |
|
@sethvargo should I run them with my random test service? I was not sure about it |
|
@momirjalili yea, and then manually edit the YAML to remove your API key and replace it with |
|
@sethvargo sorry, it took me a while to get back to this, now the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Currently only dynamic snippets support, this is an effort to add update capability for normal snippets and cover https://docs.fastly.com/api/config#snippet_e74c500822f252e309a03e0d2727d7b3
I added unittests, but since all the tests were run with a particular service id, I didn't know the policy of how new contributions are accepted. I would be happy if you guide me on this.