fix(automation_tokens): Fix decodeBodyMap for string to time.Time #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse-Hills
changed the title
|
Hi @Jesse-Hills please update your branch to be up to date with |
Jesse-Hills
force-pushed
the
fix_automation_token_creation
branch
2 times, most recently
from
4c23a69 to
8b839d5
Compare
…es in API response - Update `CreateAutomationTokenInput` to allow omitting ExpiresAt and have a token that doesn't expire - Update decoder to handle empty string for time.Time values
Jesse-Hills
force-pushed
the
fix_automation_token_creation
branch
from
8b839d5 to
9afbfc0
Compare
|
Hi @anthony-gomez-fastly, I've made the requested changes, please let me know if there are any other blockers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Resolves #575
This change resolves the issue in decodeBodyMap when attempting to parse strings as
time.Timewhen the returned value is an empty string.It appears the API changed its default behaviour since support for
AutomationTokenswas added, most notably:time.Time(0001-01-01T00:00:00Z) forExpiresAtwhich resulted in a token with no expiry ("expires_at":null)"expires_at":nullor omit it from the request.time.Timeforlast_used_at(can be seen in the diff for the test fixtures) which decoded fine but the default response has changed to an empty string which now fails to parse."expires_at":""which will result in the same error being seen by"last_used_at":""in the linked issue.Are there any considerations that need to be addressed for release?
This should be low risk as the change only impacts the decoding of objects that have a
time.Timefield, and only changes the behaviour if the endpoint returned an empty string for that field - meaning the endpoint wouldn't currently work without this change.