test(product_enablement): Add test suites for all supported products. #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All supported products now have test suites which test 'get', 'enable', and 'disable' functionality. This requires using a Compute service for testing as the Fanout product can only be enabled on Compute services. Additionally some small improvements were made in the core product enablement code: unnecessary usage of 'fmt' was removed, and the 'enable' operation now sends the API call with a JSON body instead of a www-form-urlencoded body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All supported products now have test suites which test 'get',
'enable', and 'disable' functionality. This requires using a Compute
service for testing as the Fanout product can only be enabled on
Compute services.
Additionally some small improvements were made in the core product
enablement code: unnecessary usage of 'fmt' was removed, and the
'enable' operation now sends the API call with a JSON body instead of
a www-form-urlencoded body.