add limit_workspaces to user model #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
approved these changes
Jun 4, 2024
| @@ -13,6 +13,7 @@ type User struct { | |||
| DeletedAt *time.Time `mapstructure:"deleted_at"` | |||
| EmailHash *string `mapstructure:"email_hash"` | |||
| LimitServices *bool `mapstructure:"limit_services"` | |||
| LimitWorkspaces *bool `mapstructure:"limit_workspaces"` | |||
There was a problem hiding this comment.
I was checking the customer API https://www.fastly.com/documentation/reference/api/account/customer/ and I don't see the limit_workspaces field documented. It's not a blocker for this PR but it's usually a good idea to make sure the docs are updated to reflect the latest interface.
There was a problem hiding this comment.
@Integralist thank you for reviewing this! We're planning to update the API docs after we release this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fastly UI needs to read the
limit_workspacesattribute from theGET /user/:user_idresponse in order to determine whether to display the list of workspaces on the user management screen for each user