feat: domain inspector #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Nov 9, 2023
| // GroupBy is the dimensions to return in the query. | ||
| GroupBy []string | ||
| // Limit is the limit of returned data | ||
| Limit int |
There was a problem hiding this comment.
I don't see this being referenced or passed through anywhere.
| // End is a valid ISO-8601-formatted date and time, or UNIX timestamp, indicating the exclusive end of the query time range. If not provided, a default is chosen based on the provided downsample value. | ||
| End time.Time | ||
| // GroupBy is the dimensions to return in the query. | ||
| GroupBy []string |
There was a problem hiding this comment.
I don't see this being referenced or passed through anywhere.
There was a problem hiding this comment.
Thanks for catching. Fixed.
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for getting historical per-domain metrics provided by Domain Inspector.
Fastly API docs: https://developer.fastly.com/reference/api/metrics-stats/domain-inspector/historical/
Further details: https://docs.fastly.com/products/domain-inspector