Update FTP logging endpoint #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename FTP.Username => FTP.User for consistency * Add FTP.PublicKey * Pointers in CreateFTPInput, UpdateFTPInput and use helpers in tests * Change GzipLevel from uint8 to uint for consistency
mccurdyc
reviewed
May 8, 2020
1 task
|
@phamann and I talked about this. While this is what we would like the API to be eventually (e.g., pointers, etc.), we can't make some of these changes right now without releasing a major version of the client, which we aren't ready to do. So, for this change, we will focus on additions to the API, but no in-place changes and will note for these changes to be made in a v2 release of the client. |
mccurdyc
reviewed
May 11, 2020
mccurdyc
reviewed
May 12, 2020
mccurdyc
reviewed
May 12, 2020
mccurdyc
reviewed
May 12, 2020
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
mccurdyc
reviewed
May 12, 2020
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
mccurdyc
reviewed
May 12, 2020
| @@ -169,6 +176,14 @@ func TestClient_FTPs(t *testing.T) { | |||
| if uftp.Name != "new-test-ftp" { | |||
| t.Errorf("bad name: %q", uftp.Name) | |||
| } | |||
| // TODO (v2): This is a bug where updates to zero-values are omitted due to the | |||
There was a problem hiding this comment.
@phamann test that exercises the bug with a note for v2.
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
phamann
requested changes
May 12, 2020
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edits by @mccurdyc)
Rename Username to User for consistency with API fieldUse pointers in CreateFTPInput and UpdateFTPInput structs and use helpers in testsChange GzipLevel from uint8 to uint for consistencyThe crossed-out fields are breaking changes and need to wait for v2.