Add NewRealtimeStatsClientForEndpoint API #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an RTSClient counterpart to NewClientForEndpoint. The existing API (NewRealtimeStatsClient) requires FASTLY_API_KEY to be set in the environment, and panics if the endpoint url cannot be parsed. This new API doesn't make any environment requirements and returns an error if its endpoint cannot be parsed, making it more flexible for embedding in applications. Fixes fastly#118
pteichman
force-pushed
the
pteichman/new-realtime-client
branch
from
b09b933 to
6a714b5
Compare
phamann
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an RTSClient counterpart to NewClientForEndpoint.
The existing API (NewRealtimeStatsClient) requires FASTLY_API_KEY
to be set in the environment, and panics if the endpoint url
cannot be parsed.
This new API doesn't make any environment requirements and returns
an error if its endpoint cannot be parsed, making it more flexible
for embedding in applications.
Fixes #118