Implement batch operations for dictionary items #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 12, 2019 17:46
…overing create, delete, update and upsert.
… the maximum operations size.
matpimenta
reviewed
Jul 16, 2019
phamann
approved these changes
Jul 17, 2019
added 3 commits
July 22, 2019 12:12
… and duplicates removed from fixtures.
philippschulte
deleted the
implement-batch-operations-for-dictionary-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary focus of this PR is to introduce batch operations, (Create, Update, Upsert and delete) covering dictionary items.
The dictionary item function
BatchModifyDictionaryItemsexecutes a list of BatchDictionaryItem against the FASTLY API endpoint PATCH/service/service_id/dictionary/dictionary_id/itemsThe Batch Operations have been placed in a common location, (fastly.go) because they are also used with the Batch endpoint for ACLS, (coming in a separate PR after this has been merged).
The tests around the dictionary, dictionary items and dictionary items batch have been refactored to aid reading. The tests covering dictionary items and the batches set up their own services for the test and the tear them down. The fixtures have been updated to reflect the current request/response accepted by the Fastly API above.