Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public is_cri_async and a get_cri_socket_paths methods to CRI container engine #2022

Closed
incertum opened this issue Aug 26, 2024 · 7 comments
Closed

Add public is_cri_async and a get_cri_socket_paths methods to CRI container engine #2022

incertum opened this issue Aug 26, 2024 · 7 comments
Labels
good first issue Good for newcomers kind/feature New feature or request
Milestone
0.20.0

Comments

@incertum
Copy link
Contributor

Add public is_cri_async and a get_cri_socket_paths methods to CRI container engine.

See /~https://github.com/falcosecurity/falco/pull/3266/files#r1659341853
@incertum incertum added kind/feature New feature or request good first issue Good for newcomers labels Aug 26, 2024
@incertum incertum mentioned this issue Aug 26, 2024
Merged
@falcosecurity falcosecurity deleted a comment Aug 26, 2024
@incertum
Copy link
Contributor Author

^ I deleted a comment where someone posted an unrelated link with a password.

@incertum
Copy link
Contributor Author

One more related improvement for tracking here falcosecurity/falco#3266 (comment)

@FedeDP
Copy link
Contributor

FedeDP commented Aug 27, 2024

/milestone 0.19.0

(if there is anyone willing to make it for 0.18.0, we can move it to the correct milestone later!)

@poiana poiana added this to the 0.19.0 milestone Aug 27, 2024
@incertum
Copy link
Contributor Author

This is not urgent and more of a nice to have. 0.19.0 seems great!

@FedeDP
Copy link
Contributor

FedeDP commented Nov 13, 2024

/milestone 0.20.0

@poiana poiana modified the milestones: 0.19.0, 0.20.0 Nov 13, 2024
This was referenced Nov 13, 2024
Open
Open
@FedeDP
Copy link
Contributor

FedeDP commented Jan 3, 2025

Given falcosecurity/falco#3403, i don't think this will be needed anymore!

/close

@poiana poiana closed this as completed Jan 3, 2025
@poiana
Copy link
Contributor

poiana commented Jan 3, 2025

@FedeDP: Closing this issue.

In response to this:

Given falcosecurity/falco#3403, i don't think this will be needed anymore!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
3 participants
@FedeDP @incertum @poiana