-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: add support for bottlerocket os #79
Conversation
I tested both minikube and bottlerocket output, and it looks good!
|
What we need more:
|
97a31e5
to
6161331
Compare
/cc @leogr @EXONER4TED |
/hold |
TODO:
|
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…inikube and bottlerocket. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
6161331
to
62ed9da
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rom amazonlinux2, then patch its config with its flavor-specific ones. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
We (me and @alacuku , thank you Aldo <3) found out that the config-bottlerocket file is indeed not the full config, but just a patch to be applied on top of an amazonlinux2 base kernel (specified in the kernel spec file: /~https://github.com/bottlerocket-os/bottlerocket/blob/develop/packages/kernel-5.10/kernel-5.10.spec#L10); config-bottlerocket enables FS related kernel configs; then we must also pick the correct config patch for each flavor, and apply it on top of the base config. New example with kernelconfigdata fixed:
|
…tionary. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
So, we were able to test that the driver built from the crawler versions, together with driverkit patch, worked on a 1.11.1 bottlerocket instance. Thanks to @alacuku for helping me in testing this on a EKS bottlerocket cluster :) |
…lly. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
And last commit made the discover of kernel versions and flavors support matrix for bottlerocket dynamic ;) |
/unhold |
@@ -24,7 +24,7 @@ jobs: | |||
|
|||
- name: Run crawler | |||
run: | | |||
kernel-crawler crawl --distro "*" --out_fmt driverkit > kernels.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update driverkit docs to remove any references to the old format, since we've stabilized on a format. 🚀
Signed-off-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: David Windsor <dwindsor@secureworks.com>
Good call, I wonder how many users of the non-driverkit formats there are in the other builders? I was under the impression that you were deprecating the non-driverkit formats for all builders, but IIUC this only applies to Minikube-style builders? |
Nope, i completely dropped non-driverkit outputs ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it 👍
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area crawler
What this PR does / why we need it:
The PR adds support for bottlerocket OS, following same git pattern of minikube.
Moreover, given that lots of code was shared between the 2 distros, a common
GitMirror
class has been added.Finally, given that non-driverkit output was practically unsupported on both minikube and bottlerocket, i chose to drop support for non-driverkit outputs; we do not use them and moving forward, we will only support the driverkit-like json approach.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: