Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement driver loading capabilities in falcoctl #327

Closed
LucaGuerra opened this issue Sep 27, 2023 · 6 comments
Closed

Implement driver loading capabilities in falcoctl #327

LucaGuerra opened this issue Sep 27, 2023 · 6 comments
Assignees
Milestone

Comments

@LucaGuerra
Copy link
Contributor

LucaGuerra commented Sep 27, 2023

What would you like to be added:

According to this proposal: /~https://github.com/falcosecurity/falco/blob/master/proposals/20221129-artifacts-distribution.md#deprecate-falco-driver-loader we need a new home for the Falco driver loader. This issue acts as a basic requirement specification for this and as a place for discussion. The issue will be updated with more details as it's being developed.

This issue covers feature parity with the driver loader script. The main required features are:

  • Distribution detection
  • Ability to download prebuilts from https://download.falco.org
  • Ability to compile with the local toolchain (i.e. the one available in the container image or the one in the host)
  • Options to select compilation, download or both with fallback
  • Options to select kmod or (classic) bpf probe -- the modern ebpf probe does not need a driver loader
  • Support for at least debian, ubuntu, amzn, flatcar, minikube, bottlerocket, talos and generic

In addition, the design should allow for other projects using the Falco libs to use falcoctl or import it into their own Go-based tooling, meaning that their strategy to download and build prebuilt could be a little different and the design should still allow for that to work. In addition, it should be easier for contributors to add support for their own favorite distribution, since it has proven to be a bit hard to do the same in the bash script.

Why is this needed:

/~https://github.com/falcosecurity/falco/blob/master/proposals/20221129-artifacts-distribution.md#deprecate-falco-driver-loader

@leogr
Copy link
Member

leogr commented Oct 20, 2023

/assign @FedeDP
/assign @LucaGuerra

@leogr leogr moved this from Todo to In progress in Falco Roadmap Oct 20, 2023
@leogr leogr added this to the v0.7.0 milestone Oct 20, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Nov 21, 2023

Still missing:

  • tests
  • fix up driver type names to match new: driver selection in falco.yaml falco#2413 once it get merged (eg: modern-bpf will become modern-ebpf) and eventually other Falco config changes
  • Improvements, eg: use unix.lsmod/insmod etc etc instead of exec.Command to reduce exec.Command usages

@FedeDP
Copy link
Contributor

FedeDP commented Nov 21, 2023

I'd like to tag a 0.7.0-alpha once falcosecurity/falco#2413 is merged and needed changes land in falcoctl, to be able to test Falco with the new driver-loader.

@leogr
Copy link
Member

leogr commented Nov 22, 2023

I'd like to tag a 0.7.0-alpha once falcosecurity/falco#2413 is merged and needed changes land in falcoctl, to be able to test Falco with the new driver-loader.

I'll take a look at falcosecurity/falco#2413 soon 👍

@FedeDP
Copy link
Contributor

FedeDP commented Dec 14, 2023

IMHO we can close this one; Falco master now ships the new driver loader, and tests are ongoing.
Not much development left (except for fixing bugs if they happen).
/close

@poiana poiana closed this as completed Dec 14, 2023
@poiana
Copy link
Contributor

poiana commented Dec 14, 2023

@FedeDP: Closing this issue.

In response to this:

IMHO we can close this one; Falco master now ships the new driver loader, and tests are ongoing.
Not much development left (except for fixing bugs if they happen).
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants